Project

General

Profile

Actions

Task #95341

closed

`grunt scripts` generates double-compressed javascript files

Added by Benjamin Franzke over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
Start date:
2021-09-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Execute

(cd Build; node_modules/.bin/grunt build)
(cd Build; node_modules/.bin/grunt scripts)
git status

Output:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
    modified:   typo3/sysext/adminpanel/Resources/Public/JavaScript/AdminPanel.js
    modified:   typo3/sysext/adminpanel/Resources/Public/JavaScript/Modules/Cache.js
    modified:   typo3/sysext/adminpanel/Resources/Public/JavaScript/Modules/Preview.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/ActionButton/AbstractAction.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/BackendException.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/ColorPicker.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Event/ConsumerScope.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/FlexFormSectionContainer.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/InlineControlContainer.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Container/SiteLanguageContainer.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/CategoryElement.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Extra/SelectBoxFilter.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/InputLinkElement.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/MfaInfoElement.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Modifier/Resizable.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/Modifier/Tabbable.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SlugElement.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/FieldWizard/LocalizationStateSelector.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/FormEngineSuggest.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/GlobalEventHandler.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/GridEditor.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Icons.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/LayoutModule/Paste.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/LiveSearch.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Localization.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Login.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/LoginRefresh.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/MultiStepWizard.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/NewMultiplePages.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Popover.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Storage/AbstractClientStorage.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Storage/Persistent.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Tabs.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ClearCacheMenu.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/ShortcutMenu.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Toolbar/SystemInformationMenu.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Tree/DragDrop.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageBrowser.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Tree/PageBrowser.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Viewport.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Viewport/AbstractContainer.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationContainer.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Viewport/Toolbar.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Wizard.js
    modified:   typo3/sysext/backend/Resources/Public/JavaScript/Wizard/NewContentElement.js
    modified:   typo3/sysext/backend/Tests/JavaScript/NotificationTest.js
    modified:   typo3/sysext/core/Resources/Public/JavaScript/Ajax/AjaxRequest.js
    modified:   typo3/sysext/core/Resources/Public/JavaScript/Ajax/AjaxResponse.js
    modified:   typo3/sysext/core/Resources/Public/JavaScript/Ajax/ResponseError.js
    modified:   typo3/sysext/core/Tests/JavaScript/Ajax/InputTransformerTest.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/ChartInitializer.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/DashboardDelete.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/DashboardModal.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/Grid.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetContentCollector.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetRemover.js
    modified:   typo3/sysext/dashboard/Resources/Public/JavaScript/WidgetSelector.js
    modified:   typo3/sysext/extensionmanager/Resources/Public/JavaScript/Repository.js
    modified:   typo3/sysext/extensionmanager/Resources/Public/JavaScript/Update.js
    modified:   typo3/sysext/extensionmanager/Resources/Public/JavaScript/UploadForm.js
    modified:   typo3/sysext/filelist/Resources/Public/JavaScript/ContextMenuActions.js
    modified:   typo3/sysext/filelist/Resources/Public/JavaScript/FileDelete.js
    modified:   typo3/sysext/impexp/Resources/Public/JavaScript/ContextMenuActions.js
    modified:   typo3/sysext/impexp/Resources/Public/JavaScript/ImportExport.js
    modified:   typo3/sysext/info/Resources/Public/JavaScript/TranslationStatus.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Install.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Installer.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Module/AbstractInlineModule.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Module/AbstractInteractableModule.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Module/PasswordStrength.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Module/Settings/SystemMaintainer.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/UpgradeDocs.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Renderable/FlashMessage.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Renderable/InfoBox.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Renderable/ProgressBar.js
    modified:   typo3/sysext/install/Resources/Public/JavaScript/Router.js
    modified:   typo3/sysext/linkvalidator/Resources/Public/JavaScript/Linkvalidator.js
    modified:   typo3/sysext/lowlevel/Resources/Public/JavaScript/QueryGenerator.js
    modified:   typo3/sysext/lowlevel/Resources/Public/JavaScript/ReferenceIndex.js
    modified:   typo3/sysext/opendocs/Resources/Public/JavaScript/Toolbar/OpendocsMenu.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/BrowseDatabase.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/FileLinkHandler.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/LinkBrowser.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/MailLinkHandler.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/PageLinkHandler.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/RecordLinkHandler.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/RecordSearch.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/TelephoneLinkHandler.js
    modified:   typo3/sysext/recordlist/Resources/Public/JavaScript/UrlLinkHandler.js
    modified:   typo3/sysext/tstemplate/Resources/Public/JavaScript/ConstantEditor.js
    modified:   typo3/sysext/workspaces/Resources/Public/JavaScript/Workspaces.js

Expected:

No changed files.

Issue is that `grunt scripts` uses `newer:terser:typescript` while `grunt build` does not and therefore `grunt scripts` retersed all files on the first run after `grunt build` has been executed.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #95016: Run grunt scripts in parallelClosed2021-08-27

Actions
Actions #1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71226

Actions #2

Updated by Benjamin Franzke over 2 years ago

  • Related to Task #95016: Run grunt scripts in parallel added
Actions #3

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71226

Actions #4

Updated by Benjamin Franzke over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF