Project

General

Profile

Actions

Bug #95444

closed

DataHandler - server-side log message is rendered incorrectly

Added by Davide Alghi about 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Miscellaneous
Target version:
-
Start date:
2021-10-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The problem is DataHandler::log call. The funcion is called with incorrect "$details" (6th) and "$data" (8th) params
"$details" should contain translated message format with directives.
"$data" should contain an array with parameters for "$details".
Issue is in TYPO3 v10 and TYPO3 v11

Steps to reproduce:
1) force feuser "Email" field with "email" evaluation: i.e. add "email" in TCA, here https://github.com/TYPO3/typo3/blob/6c07327fae82554d9a689eff5a007e5eb10a9781/typo3/sysext/frontend/Configuration/TCA/fe_users.php#L131
1a) clear the cache
2) edit a feuser
3) in "Personal Data::Email" field enter a text other than an email address
4) save
5) the error message shown has wrong message
6) in this case the "funcion log" call is https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L2723

Incorrect calls are:
https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1443
https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L2723

Wrong message

=================================================================================

Also there are translated strings but not used

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L867
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51210

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L967
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51212

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1395
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51236

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L1409
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51238

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L2393
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51256

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L3092
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51210

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4093
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51234

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4208
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51220

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4210
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51222

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4213
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51224

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4225
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51226

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4267
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51220

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4269
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51222

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4272
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51224

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4284
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51226

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L4287
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51232

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L6653
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51206
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51228

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L6657
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51208
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51230

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L7184
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#62880
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#62878

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L7193
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51216

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L7292
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51216

https://github.com/TYPO3/typo3/blob/aa2ed9495a5c5cdb01fc1e2858bff2c64cb7a89d/typo3/sysext/core/Classes/DataHandling/DataHandler.php#L7617
https://crowdin.com/translate/typo3-cms/all/en-it?filter=basic&value=3#51218


Files

datahandler_logCallIssue.png (22.8 KB) datahandler_logCallIssue.png Davide Alghi, 2021-10-02 08:39

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Task #95445: Fixes datahandler-logCallIssueClosed2021-10-02

Actions
Related to TYPO3 Core - Bug #95464: Invalid email address notification in BE form doesn't show correctlyClosed2021-10-04

Actions
Actions #1

Updated by Davide Alghi about 3 years ago

My proposal for master and TYPO3 v10

https://github.com/TYPO3/typo3/pull/326

Actions #2

Updated by Davide Alghi about 3 years ago

  • Related to Task #95445: Fixes datahandler-logCallIssue added
Actions #3

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71414

Actions #4

Updated by Georg Ringer about 3 years ago

  • Related to Bug #95464: Invalid email address notification in BE form doesn't show correctly added
Actions #5

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71414

Actions #6

Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/71414

Actions #7

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72105

Actions #8

Updated by Anonymous about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF