Bug #95814: The itemsProcFunc configuration array has wrong pid from the 2nd content element on a page - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #95814

closed

The itemsProcFunc configuration array has wrong pid from the 2nd content element on a page

Added by Andreas Kalkhoff about 3 years ago. Updated 5 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend API

Target version:

Start date:

2021-10-29

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

7.4

Tags:

Complexity:

Is Regression:

Yes

Sprint Focus:

Description

I use an itemProcFunc to fill flexform items based on heritage-based data; filling an array of colors for editors to use which may differ based on the site they are editing.
This seems to be a regression considering issue #50551. Georg Ringer advised to use "$config['flexParentDatabaseRow']['pid']" as solution to that issue as the code base changed a lot since the creation of said issue.
$config['flexParentDatabaseRow']['pid'] however seems to have the same issue:
When I click "+ Content" after any element on a page "$config['flexParentDatabaseRow']['pid']" returns that prior element's uid as negative as pid. I do only get the proper pid on the topmost "+ Content" that's not affiliated to a content element.

E.g.:
On Page ID 345
(1) "+ Content"
(2) tt_content element uid 123 (any type, text or whatever)
(3) "+ Content"

(1) $config['flexParentDatabaseRow']['pid'] returns "345"
(3) $config['flexParentDatabaseRow']['pid'] returns "-123"

Files

flexParentDatabaseRow.png (4.89 KB) flexParentDatabaseRow.png

Andreas Kalkhoff, 2021-10-29 06:25

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Andreas Kalkhoff about 3 years ago

Related to Bug #50551: The itemsProcFunc configuration array has wrong pid from the 2nd content element on a page added

Actions

Copy link

Updated by Mike Street over 2 years ago

I am using v10.4.28 and can confirm this exists.

The code suggested from the related issue (https://forge.typo3.org/issues/50551#note-8) helped me resolve in this instance, but does seem unusual to have a property called `pid` return not the PID

$this->contentElementPid = $config['row']['pid'];

// if $config['row']['pid'] is < 0 then it points
// to the previous content element on the same page
if ($this->contentElementPid < 0) {
    $parentRec = \TYPO3\CMS\Backend\Utility\BackendUtility::getRecord(
            'tt_content',
            abs($this->contentElementPid),
            'pid'
    );

    $this->contentElementPid = $parentRec['pid'];
}