Project

General

Profile

Actions

Task #96551

closed

Epic #96521: Enhance PhpStan coverage

Use proper QueryBuilder execute() replacements executeQuery() and executeStatement()

Added by Stefan Bürk almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2022-01-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #96972: Deprecate QueryBuilder::execute()ClosedStefan Bürk2022-02-20

Actions
Actions #1

Updated by Stefan Bürk almost 3 years ago

  • Category set to Database API (Doctrine DBAL)
  • Parent task set to #96521

Replaceing doctrine/dbal execute() with executeQuery() for count/select queries
and executeStatement() for insert/update/delete queries would have following
benefits:

- solves core phpstan errors which are currently swallowed by checkThisOnly config
- prepare/cleanup the core and avoid using the to-be deprecated method execute() early
- start early to get firm with the new methods and be a demonstration for developers

Actions #2

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73032

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73032

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73032

Actions #5

Updated by Gerrit Code Review almost 3 years ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73032

Actions #6

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73055

Actions #7

Updated by Stefan Bürk almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Stefan Bürk almost 3 years ago

  • Related to Task #96972: Deprecate QueryBuilder::execute() added
Actions #9

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF