Project

General

Profile

Actions

Bug #96563

closed

LanguageMenuProcessor.php

Added by Tim Krämer almost 3 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2022-01-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
7.4
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hello,

I'm neither a typo3 nor php developer, and I don't know if this is the right place? Do you have a repo where I can create a proper pull request somewhere?
Anyway one of my customers has a typo3 v11.5.5 installed and has hundred's instances of an error in their log-files nagging about a problem with $menu on line 420 of typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php - I fixed it with a if(is_iterable($menu)) clause. Again, I'm not a php developer, there might be a proper way to do this, but it fixes the problem. My customer and I would be very happy to not have to manually patch this after every typo3 update...
So please include it (or a better fix) in the next release. Thank you!

            if(is_iterable($menu)) {
                foreach ($menu as $key => $language) {
                    $processedMenu[$key] = $language;
                }
            }
Actions #1

Updated by Lina Wolf almost 3 years ago

  • Category set to TypoScript

A warm welcome to you. You are at the correct place to report suspected Core issues. If you also want to contribute, you can have a look at https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/

I think this is a problem surrounding TypoScript so I put the category for you. This should make your issue easier to be seen. Please do not feel discouraged if you don't get a feedback right away. Most developers are contributing in their free time.

You might want to try out to use https://github.com/b13/menus that is what I usually use for language menus.

Actions #2

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73142

Actions #3

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73142

Actions #4

Updated by Gerrit Code Review almost 3 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73091

Actions #5

Updated by Oliver Bartsch almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF