Task #96703: Fix definition availability checks in DI compiler passes - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #96703

closed

Fix definition availability checks in DI compiler passes

Added by Benjamin Franzke almost 3 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Benjamin Franzke

Category:

Target version:

Start date:

2022-01-31

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

findDefinition() doesn't actually return a boolean (or null)
value on failure but throws an exception instead. As an alternative
$container->hasDefintion may be used to check for definition availability.

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73241

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73241

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73241

Actions

Copy link

Updated by Benjamin Franzke almost 3 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 1cd63e30ad56621efc230b9bef0dd5c87ed1c682.

Actions

Copy link

Updated by Gerrit Code Review almost 3 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73244

Actions

Copy link