Project

General

Profile

Actions
Copy link

Bug #96824

open

FolderStructure DefaultFactor doesn't repect configured group

Added by Markus Goldbach almost 3 years ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
CLI
Target version:
-
Start date:
2022-02-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If you create the default file and folder structure for the var-Folder via command bin/typo3cms install:fixfolderstructure the DefaultFactory (\TYPO3\CMS\Install\FolderStructure\DefaultFactory) doesn't respect the configuiered createGroup.
So the files and folders has the default group of the current user.

I looked inside the Directory and FileNode class and instead of using the methods from GeneralUtility the classes use plain PHP function to create the items.

I think the command should respect the createGroup Option, otherwise an installation can be broken after run this command, if the current user has not the webserver group as default group or is the webserver user.

I added two patches for the "typo3/cms-install" Package which fix the issue by using the functions from GeneralUtility.

Files

Download all files
directory_node.patch (982 Bytes) directory_node.patch Markus Goldbach, 2022-02-11 09:11
file_node.patch (932 Bytes) file_node.patch Markus Goldbach, 2022-02-11 09:11
Actions
Copy link
 #1

Updated by Markus Goldbach almost 3 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #4

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #5

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #6

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #7

Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #8

Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #9

Updated by Gerrit Code Review about 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link
 #10

Updated by Gerrit Code Review about 1 month ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73490

Actions
Copy link

Also available in: Atom PDF