Project

General

Profile

Actions

Bug #96853

closed

The slug generator via ajax is not workspace aware

Added by Imko Schumacher about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Workspaces
Start date:
2022-02-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The slug generator via ajax is not workspace aware.
This causes Recalculate URL segment from ... to check the wrong collision domain and collide with the live record.

Prerequisite

  • workspace
    • activate the extension
    • create a workspace

Steps to reproduce

  1. Create a page in the live workspace with the title workspace-slug
    • make sure, that the URL segment is /workspace-slug (may need to use recalculate button)
  2. Save page
  3. Switch to a workspace
  4. Edit the same page and save it (we need a WS version to be created)
  5. Press the Recalculate URL segment from page title button

Actual behavior

  • The requested URL is already in use, but ... (adds a suffix)

Expected behavior

  • Slug stays the same since it falls under different constraints (SlugHelper is workspace aware)

Solution

Environment

  • Tested typo3 versions
    • main (3634cd0385427dd4af97ec89e7646a7e24b81b6a)
    • 11.5.5
    • 10.4

Files

workspace-slug-actual.png (6.57 KB) workspace-slug-actual.png Imko Schumacher, 2022-02-12 11:53
workspace-slug-expected-fixed.png (5.91 KB) workspace-slug-expected-fixed.png Imko Schumacher, 2022-02-12 11:53
Actions #1

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73449

Actions #2

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73449

Actions #3

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74298

Actions #4

Updated by Imko Schumacher about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74298

Actions #6

Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74298

Actions #7

Updated by Imko Schumacher about 2 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF