Bug #96853
closedThe slug generator via ajax is not workspace aware
100%
Description
The slug generator via ajax is not workspace aware.
This causes Recalculate URL segment from ...
to check the wrong collision domain and collide with the live record.
Prerequisite¶
- workspace
- activate the extension
- create a workspace
Steps to reproduce¶
- Create a page in the live workspace with the title
workspace-slug
- make sure, that the URL segment is
/workspace-slug
(may need to use recalculate button)
- make sure, that the URL segment is
- Save page
- Switch to a workspace
- Edit the same page and save it (we need a WS version to be created)
- Press the
Recalculate URL segment from page title
button
Actual behavior¶
The requested URL is already in use, but ...
(adds a suffix)
Expected behavior¶
- Slug stays the same since it falls under different constraints (SlugHelper is workspace aware)
Solution¶
- Pass workspaceId to the SlugHelper constructor
Environment¶
- Tested typo3 versions
- main (3634cd0385427dd4af97ec89e7646a7e24b81b6a)
- 11.5.5
- 10.4
Files
Updated by Gerrit Code Review almost 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73449
Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73449
Updated by Gerrit Code Review over 2 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74298
Updated by Imko Schumacher over 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 2695175b5993057270845b6152f39987eba5bcb7.
Updated by Gerrit Code Review over 2 years ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74298
Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74298
Updated by Imko Schumacher over 2 years ago
- Status changed from Under Review to Resolved
Applied in changeset 1d504448df57e76fbaf5a9af491f34834c1e2765.