Bug #96922: FAL file DuplicationBehavior::REPLACE is using public file path - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #96922

open

FAL file DuplicationBehavior::REPLACE is using public file path

Added by Sascha Egerer almost 3 years ago. Updated over 2 years ago.

Status:

New

Priority:

Should have

Assignee:

Category:

File Abstraction Layer (FAL)

Target version:

Start date:

2022-02-16

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

When a file is uploaded with an existing name there are different behaviors to choose from.
One is the DuplicationBehavior::REPLACE which should replace the existing file.

Currently the "public path" of the file is used to get the file on the storage which does not make sense and fails, if the public path is returning something else then it is on the storage.

See https://github.com/TYPO3/typo3/blob/bc15ad4b24a3c76087a2aa1172d44cb84fe0569c/typo3/sysext/core/Classes/Resource/ResourceStorage.php#L2068

The public path must not be used to do file operations on the storage but only to provide a path for the public (web) usage.

Files

Bildschirmfoto 2022-08-05 um 21.23.50.png (125 KB) Bildschirmfoto 2022-08-05 um 21.23.50.png

Sascha Egerer, 2022-08-05 19:23

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Sascha Egerer over 2 years ago

Related to Bug #98005: Use sanitized filename as source identifier when replacing an image added

Actions

Copy link

Updated by Simon Schaufelberger over 2 years ago

Currently the "public path" of the file is used to get the file on the storage which does not make sense and fails, if the public path is returning something else then it is on the storage.

How can this be reproduced?

Actions

Copy link