Bug #97329: Missing isset in indexed_search SearchController.php - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #97329

closed

Missing isset in indexed_search SearchController.php

Added by Preben Rather Sørensen over 2 years ago. Updated about 2 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Indexed Search

Target version:

Start date:

2022-04-07

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

8.0

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

In typo3/sysext/indexed_search/Classes/Controller/SearchController.php line 492 and 538 there is a missing isset

if ($GLOBALS['TSFE']->config['config']['fileTarget'])

Should be

if (isset($GLOBALS['TSFE']->config['config']['fileTarget']))

The missing isset cause an error in frontend under certain circumstances:

PHP Warning: Undefined array key "fileTarget" in /var/www/html/private/typo3/sysext/indexed_search/Classes/Controller/SearchController.php line 492

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74218

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74218

Actions

Copy link

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74235

Actions

Copy link