Project

General

Profile

Actions

Bug #97427

closed

Use proper EventDispatcherInterface mock

Added by Stefan Bürk over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2022-04-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

1) TYPO3\CMS\Extensionmanager\Tests\Unit\Utility\InstallUtilityTest::siteConfigGetsMovedIntoPlace
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php:551
/var/www/work/typo3-play/master/src/typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php:196
/var/www/work/typo3-play/master/src/typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php:357
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

2) TYPO3\CMS\Extensionmanager\Tests\Unit\Utility\InstallUtilityTest::siteConfigGetsNotOverriddenIfExistsAlready
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php:551
/var/www/work/typo3-play/master/src/typo3/sysext/extensionmanager/Classes/Utility/InstallUtility.php:196
/var/www/work/typo3-play/master/src/typo3/sysext/extensionmanager/Tests/Unit/Utility/InstallUtilityTest.php:432
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

3) TYPO3\CMS\Frontend\Tests\Unit\ContentObject\ContentObjectRendererTest::typolinkReturnsCorrectLinksForEmailsAndUrls with data set "Link to url with attributes" ('TYPO3', array('http://typo3.org', 'class="url-class"', '_blank', 'Open new window'), '<a href="http://typo3.org" ti...O3</a>')
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:103
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:143
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:57
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2943
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4793
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4754
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4693
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:2412
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

4) TYPO3\CMS\Frontend\Tests\Unit\ContentObject\ContentObjectRendererTest::typolinkReturnsCorrectLinksForEmailsAndUrls with data set "Link to url with attributes and custom target name" ('TYPO3', array('http://typo3.org', 'class="url-class"', 'someTarget', 'Open new window'), '<a href="http://typo3.org" ti...O3</a>')
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:103
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:143
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:57
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2943
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4793
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4754
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4693
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:2412
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

5) TYPO3\CMS\Frontend\Tests\Unit\ContentObject\ContentObjectRendererTest::typolinkReturnsCorrectLinksForEmailsAndUrls with data set "Link to url with attributes in parameter" ('TYPO3', array('http://typo3.org _blank url-c...indow"'), '<a href="http://typo3.org" ti...O3</a>')
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:103
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:143
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:57
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2943
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4793
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4754
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4693
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:2412
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

6) TYPO3\CMS\Frontend\Tests\Unit\ContentObject\ContentObjectRendererTest::typolinkReturnsCorrectLinksForEmailsAndUrls with data set "Link to url with attributes in parameter and custom target name" ('TYPO3', array('http://typo3.org someTarget u...indow"'), '<a href="http://typo3.org" ti...O3</a>')
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:103
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:143
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:57
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2943
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4793
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4754
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4693
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:2412
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

7) TYPO3\CMS\Frontend\Tests\Unit\ContentObject\ContentObjectRendererTest::typolinkOpensInNewWindow
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:103
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:143
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:57
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2943
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4793
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4754
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4693
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:2860
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98

8) TYPO3\CMS\Frontend\Tests\Unit\ContentObject\ContentObjectRendererTest::typoLinkProperlyEncodesLinkResult with data set "Link parsing" ('Url', array('https://example.com _blank cs...title"', 'result'), '{"href":"https:\/\/example.co...rer"}}')
Error: Call to a member function getConfiguration() on null

/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:187
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:149
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Configuration/SiteConfiguration.php:103
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:143
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Site/SiteFinder.php:57
/var/www/work/typo3-play/master/src/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2943
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4793
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4754
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php:4693
/var/www/work/typo3-play/master/src/typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php:3015
/var/www/work/typo3-play/master/src/vendor/phpunit/phpunit/phpunit:98


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #96975: Events to adjust/be notified when site configuration is loaded/writtenClosed2022-02-20

Actions
Actions #1

Updated by Stefan Bürk over 2 years ago

  • Related to Feature #96975: Events to adjust/be notified when site configuration is loaded/written added
Actions #2

Updated by Stefan Bürk over 2 years ago

  • Description updated (diff)
Actions #3

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74352

Actions #4

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74352

Actions #5

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74352

Actions #6

Updated by Stefan Bürk over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF