Task #97654
open
[BUGFIX] Load only LIVE records in checkIfPageIsHidden
0%
Description
The `checkIfPageIsHidden` queries the page and afterwards performs the workspace overlay.
However the first query can also load workspaced records, because the restriction is missing, which means changes in the workspace can affect the preview functionality of LIVE.
Most of the times this won't break, because of the `LIMIT 1` and normally in the database the WS records will be stored after the LIVE record.
We first identified this bug in TYPO3 v10, where this bug is in `TypoScriptFrontendController`: https://github.com/TYPO3/typo3/blob/11.5/typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php#L852
There you can see there is a check for `pid > 0` in the query which is the legacy way of saying "no workspace version".
This issue was automatically created from https://github.com/TYPO3/typo3/pull/380
Updated by Gerrit Code Review over 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74680
Updated by
Updated by Gerrit Code Review over 2 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74680
Updated by Gerrit Code Review over 2 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74680
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74680
Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74680
Updated by Gerrit Code Review about 1 month ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/74680