Project

General

Profile

Actions
Copy link

Bug #97807

closed

Extension scanner does not detect usage of \TYPO3\CMS\Backend\View\PageLayoutView in v10 / v11 etc.

Added by Sybille Peters over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2022-06-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The class \TYPO3\CMS\Backend\View\PageLayoutView was deprecated in v10 and still exists in v11 and v12 (although the docblock says it will be removed in v11).

The class is marked as @internal but may have been used, for example in a hook for page layout rendering, e.g.

  • $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawFooter'][]
  • $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['cms/layout/class.tx_cms_layout.php']['tt_content_drawItem']

e.g. if you have a class like

class SlideshowPreviewRenderer implements PageLayoutViewDrawItemHookInterface
{
    // ...

    public function preProcess(
        PageLayoutView &$parentObject,

Also, the deprecated class is used in felogin in TYPO3 v10 typo3/sysext/felogin/Classes/Hooks/CmsLayout.php

Related changelogs

Actions
Copy link
 #1

Updated by Christian Kuhn over 2 years ago

Yep. Unfortunately the 'new page module' in v10 never fully removed usages of PageLayoutView and some methods are still in action. Hook consumers may type hint the class. This makes the class still tied to the 'new' solution (which comes with it's own problems). All in all, the new v10 page module introduced way more problems than it solved, and we're still suffering from it.
And yes, PageLayoutView still has to be removed, but it's still blocked by hook foo.

Actions
Copy link
 #2

Updated by Christian Kuhn almost 2 years ago

  • Status changed from New to Closed

I hope it's fine to close here for now: the class is finally gone in v12 but still needed to be referenced in v11 when using hooks.

Actions
Copy link

Also available in: Atom PDF