Project

General

Profile

Actions

Bug #98145

closed

PHP Warning: Undefined array key "config"

Added by JAKOTA Design Group GmbH over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
SEO
Start date:
2022-08-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.0
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

Hi,

I've written my own DataProvider which does not need a config.
Providing an empty config via TS like


plugin.tx_seo {
  config {
    xmlSitemap {
      sitemaps {
        entries {
          provider = VENDOR\Project\Seo\EntryXmlSitemapDataProvider
          config {
          }
        }
      }
    }
  }
}

seem error prone.

/typo3/sysext/seo/Classes/XmlSitemap/XmlSitemapRenderer.php

Line 96 is

(array)$config['config']

but should be

(array)($config['config'] ?? [])

Thanks

Actions #1

Updated by Oliver Hader about 2 years ago

  • Status changed from New to Accepted

Seems to be reasonable...

Actions #2

Updated by Gerrit Code Review about 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75529

Actions #3

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75529

Actions #4

Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/75530

Actions #5

Updated by Oliver Hader about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF