Project

General

Profile

Actions

Bug #98704

closed

doctrine/dbal 3.5.0 release shows inproper unit test setup

Added by Stefan Bürk about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2022-10-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Nightly failed and showed inproper unit test setup. Due changes
in doctrine/dbal 3.5.0 this now pops up.

See: https://github.com/doctrine/dbal/pull/5770
Pipeline: https://git.typo3.org/typo3/CI/cms/-/jobs/1663602

1) TYPO3\CMS\Core\Tests\Unit\Database\Schema\ConnectionMigratorTest::tableNamesStickToTheMaximumCharactersWhenPrefixedForRemoval
TypeError: array_filter(): Argument #1 ($array) must be of type array, null given
/builds/typo3/CI/cms/vendor/doctrine/dbal/src/Schema/SchemaDiff.php:129
/builds/typo3/CI/cms/typo3/sysext/core/Classes/Utility/GeneralUtility.php:2962
/builds/typo3/CI/cms/typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php:76
/builds/typo3/CI/cms/vendor/phpunit/phpunit/phpunit:98

2) TYPO3\CMS\Core\Tests\Unit\Database\Schema\ConnectionMigratorTest::columnNamesStickToTheMaximumCharactersWhenPrefixedForRemoval
Error: Attempt to modify property "removedColumns" on null
/builds/typo3/CI/cms/typo3/sysext/core/Tests/Unit/Database/Schema/ConnectionMigratorTest.php:94
/builds/typo3/CI/cms/vendor/phpunit/phpunit/phpunit:98
Actions #1

Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76231

Actions #2

Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/76231

Actions #3

Updated by Stefan Bürk about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF