Project

General

Profile

Actions

Bug #99244

open

DataMapper uses a lot of memory when retrieving MM-relations in workspaces

Added by Hannes Bochmann over 1 year ago. Updated 7 months ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2022-12-02
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.2
Tags:
Complexity:
hard
Is Regression:
Yes
Sprint Focus:

Description

For example in the EXT:news domain model. The getCategories() method of the news domain model uses a lot of memory when previewing a page with news records. More precisely this happens when there are a lot of categorized news records. The cause seems to be TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapper::getConstraint(). Without workspaces the resulting constraint within a getCategories() call will be "uid_foreign = $newsUid" (line 532). But in workspaces the relation IDs get resolved in another manner (line 498) and will then be used in the constraint "uid_local IN ($categoryUids)" (line 505).

So in the first case all categories of a news are retrieved. In the second case all relations to the categories of the actual news are retrieved. So something completely different. Let's say we have 20000 news records and all share the same 3 categories. Without workspaces the query will return 3 records. Inside of a workspace this query will return 60000 records or even more in case of workspace versions of news. The output in the preview seems correct in both cases so I guess the obsolete records get sorted out at a later stage.

Is the behavior of TYPO3\CMS\Extbase\Persistence\Generic\Mapper\DataMapper::getConstraint() intended or buggy?


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #82750: Workspace preview doesn't preview MM relations properlyClosed2017-10-12

Actions
Actions #1

Updated by Rémy DANIEL 7 months ago

  • Complexity set to hard
  • Is Regression set to Yes

Reproduced in TYPO3 11

Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/68913

I will submit a patch for review

Actions #2

Updated by Gerrit Code Review 7 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81166

Actions #3

Updated by Markus Klein 7 months ago

  • Related to Bug #82750: Workspace preview doesn't preview MM relations properly added
Actions #4

Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/81166

Actions #5

Updated by Rémy DANIEL 7 months ago

  • TYPO3 Version changed from 10 to 11
  • PHP Version changed from 7.4 to 8.2
Actions

Also available in: Atom PDF