Project

General

Profile

Actions

Bug #99675

closed

SiteNotFoundException thrown if page slug is changed for page without a SiteConfiguration in rootline

Added by Stefan Bürk over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Redirect Handling
Target version:
Start date:
2023-01-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If a page slug is changed and no SiteConfiguration available in
the page rootline the corresponding DataHandler Hook fails with
a SiteNotFoundException.

This is related to the streamlining of the ext:redirects auto
create chain which invokes site-configurations early in the
factory for creating the change item without properly handling
the exception. This has been a oversight in the streamlining
change.

Use-caches which triggers this are `SysFolders` directly under
the root point (PID 0) with subpages. If the sysfolder is saved
or subpages changes the excetion is thrown.

Auto create chain is based on two options which are bound to a
concrete SiteConfiguration. If no SiteConfiguration is found,
it is the same as both options are disabled or not set. Thus
the factory for the change item should handle the exception
properly and early returning to avoid any handling. Additionally,
the check for both options should also be done early do avoid the
creationg of change item sources (which may be extended by emmiting
events) which would be superflous if no handling is needed.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #99188: Streamline ext:redirects auto-create chainClosedStefan Bürk2022-11-25

Actions
Actions #1

Updated by Stefan Bürk over 1 year ago

  • Related to Task #99188: Streamline ext:redirects auto-create chain added
Actions #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77535

Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77535

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77535

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77535

Actions #6

Updated by Stefan Bürk over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF