Project

General

Profile

Task #88991

Updated by Sybille Peters about 5 years ago

* protected parameter errorParams is unnecessarily redefined in ExternalLinktype class (already introduced in parent class AbstractLinkType) 
 * initializing of errorParams done differently in each class, can be done in one way in AbstractLinkType 
 * usage of errorParams is done differently in various Linktype checker classes 
 * when the error broken link report is generated, the message is constructed twice, once when it is written into tx_linkvalidator_link.url_reponse and again when even though it is already read from the database for the report (for ExternalLinktype) 
 * -only only the errorParams['errorMessage'] needs to be stored in the database, not the rest- This is actually not a good idea because error message should be localized when report is generated rest

Back