Task #88991

Unify handling of errorParams in linkvalidator

Added by Sybille Peters over 1 year ago. Updated 26 days ago.

Status:
New
Priority:
Should have
Category:
-
Target version:
-
Start date:
2019-08-21
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • protected parameter errorParams is unnecessarily redefined in ExternalLinktype class (already introduced in parent class AbstractLinkType)
  • initializing of errorParams done differently in each class, can be done in one way in AbstractLinkType
  • usage of errorParams is done differently in various Linktype checker classes
  • the error message is constructed twice, once when it is written into tx_linkvalidator_link.url_reponse and again when it is read from the database for the report
  • only the errorParams['errorMessage'] needs to be stored in the database, not the rest This is actually not a good idea because error message should be localized when report is generated

Related issues

Related to TYPO3 Core - Task #84717: Reconsider serialized array for LinkvalidatorClosedSybille Peters2019-12-13

Actions
#1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521

#2

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521

#3

Updated by Sybille Peters over 1 year ago

  • Related to Task #84717: Reconsider serialized array for Linkvalidator added
#4

Updated by Sybille Peters over 1 year ago

  • Description updated (diff)
#5

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521

#6

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521

#7

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521

#8

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/61521

#9

Updated by Sybille Peters about 1 year ago

  • Status changed from Under Review to New
#10

Updated by Sybille Peters 26 days ago

  • Category deleted (Linkvalidator)

Also available in: Atom PDF