Project

General

Profile

Task #96706

Updated by Benjamin Franzke almost 3 years ago

Revealed due to PHPStan static analysis revealed that the method 
 exceptionForInvalidFactories() did not containa a proper setup the test 
 setup, subject properly, which went undetected as the expected TypeError 
 was thrown for the invalid test setup. 

 This could have been fixed but the test actually only 
 tried to assert whether a callable type declaration is set, mitigated by adding 
 in order to an additional check for the exception message and fixing the test whether a PHP error is thrown when an 
 invalid factory is provided. This is useless as an 
 invalid factory will result in an error in any case, 
 once tried to be called. setup. 

Back