Task #96706
closed
Remove broken test from ServiceProviderCompilationPassTest
100%
Description
PHPStan static analysis revealed that the method
exceptionForInvalidFactories() did not containa a proper test
setup, which went undetected as the expected TypeError
was thrown for the invalid test setup.
This could have been fixed but the test actually only
tried to assert whether a callable type declaration is set,
in order to test whether a PHP error is thrown when an
invalid factory is provided. This is useless as an
invalid factory will result in an error in any case,
once tried to be called.
Updated by Gerrit Code Review almost 3 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73245
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73245
Updated by Gerrit Code Review almost 3 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73245
Updated by Benjamin Franzke almost 3 years ago
- Subject changed from Fix test setup in ServiceProviderCompilationPassTest to Remove broken test from ServiceProviderCompilationPassTest
- Description updated (diff)
Updated by Gerrit Code Review almost 3 years ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73245
Updated by Gerrit Code Review almost 3 years ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73245
Updated by Gerrit Code Review almost 3 years ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73249
Updated by Gerrit Code Review almost 3 years ago
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73249
Updated by Benjamin Franzke almost 3 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 1831bc512bd5a3ef6554f7ef5da16ca35c5d426d.
Updated by Gerrit Code Review almost 3 years ago
- Status changed from Resolved to Under Review
Patch set 3 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/73249
Updated by Benjamin Franzke almost 3 years ago
- Status changed from Under Review to Resolved
Applied in changeset 9cc5d8300d71c3541d0421c3f797016993aff572.
Updated by