TYPO3 Core

fixed code sample

$query = $this->createQuery();
$query->setOrderings(array(
   'FIELD (uid, ' . implode(', ', $uidList) .')' => Tx_Extbase_Persistence_QueryInterface::ORDER_FIELD
));
return $query
  ->matching($query->in('uid', $uidList))
  ->execute();

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8619

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8619

Felix: "SQL Injection still in place ..."

I see his point. Maybe we could archive a solution which supports FIELD orderings only, but does not allow any expressions.
I had the need (using FIELD for ordering) in at least two different projects, so i think the issue is still valid.

I agree with Tobias. Had the need for FIELD ordering in two of the four last projects.

.

This is my current solution:

$orderings = array();
foreach ($ids as $_id)
{
  $orderings["uid={$_id}"] = \TYPO3\CMS\Extbase\Persistence\QueryInterface::ORDER_DESCENDING;
}

$query->setOrderings($orderings);

Wouldn't it be a more readable solution to just allow a mixed argument to setOrderings? If it is an array, behavior is like it is now, but if it is a string, it is used as-is, since that would be treated as a already well formed ORDER BY statement.

I agree that allowing strings for the ordering people might use statements that are non-portable across DBMS. But for most users that use MySQL/MariaDB nowadays (I expect) they could use orderings like RAND or giving a list of uids with a fixed order.

Please re-think if we could allow arbitrary strings "on your own risk" (maybe with a big warning in the docs or so) for certain edge-cases. And if it's not too intrusive maybe we could also allow that in 6.2 still (to stay for some years now sigh).

custom ordering is really a must have, portability is nice to have, that's the prio on all 200 projects I have done in 15 years.

Applying a custom sql order string would be very nice.

This seems to get urgent as current workarounds with parseQuery/buildQuery seem to have been gone on 6.2 :(

+1, need this and seems a failry reccurent need that it makes sense to implement it

https://stackoverflow.com/questions/46471525/typo3-8-7-query-sorting-with-flexform-uid%C2%B4s/48377727#48377727

https://www.derhansen.de/2017/05/mysql-field-function-in-typo3-87-with-doctrine.html

Here is another (easy) Solution:
https://gist.github.com/wazum/5b21cfa2f3da04189b52ea86a1da85c0