Project

General

Profile

Actions

Task #100004

closed

Add iterable types to PageErrorHandlerInterface::handlePageError()

Added by Elias Häußler almost 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2023-02-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
no-brainer
Sprint Focus:

Description

The third argument $reasons in TYPO3\CMS\Core\Error\PageErrorHandler\PageErrorHandlerInterface::handlePageError() has no iterable types defined. When providing an implementation of this interfac, PHPStan complains about them. Thus, we should add the types for this argument.

Actions #1

Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77915

Actions #2

Updated by Torben Hansen over 1 year ago

  • Subject changed from Add iterable tpyes to PageErrorHandlerInterface::handlePageError() to Add iterable types to PageErrorHandlerInterface::handlePageError()
Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77915

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77915

Actions #5

Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79733

Actions #7

Updated by Anonymous over 1 year ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF