Project

General

Profile

Actions

Task #100048

closed

Ensure that getFileContents returns correct type in YamlFileLoader

Added by Thomas Hohn over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Start date:
2023-02-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Sprint Focus:

Description

The method getFileContents in YamlFileLoader has return type string, but it has
a call to file_get_contents that can return string or false. Ensure that a string
is always returned.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #99926: PHP Warning when file does not exists.ClosedThomas Hohn2023-02-10

Actions
Actions #1

Updated by Thomas Hohn over 1 year ago

  • Subject changed from Ensure that getFileContents returns correct type to Ensure that getFileContents returns correct type in YamlFileLoader
Actions #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions #4

Updated by Simon Schaufelberger over 1 year ago

  • Related to Bug #99926: PHP Warning when file does not exists. added
Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions #7

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions #8

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77991

Actions #9

Updated by Thomas Hohn over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF