Task #100048: Ensure that getFileContents returns correct type in YamlFileLoader - TYPO3 Core - TYPO3 Forge

Custom queries

Accessibility
Easy tasks
Forge Triage
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
My open issues
No feedback within 90 days
Open Bugs
Open issues of 10
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Task #100048

closed

Ensure that getFileContents returns correct type in YamlFileLoader

Added by Thomas Hohn over 1 year ago. Updated 10 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Thomas Hohn

Category:

Target version:

Candidate for patchlevel

Start date:

2023-02-28

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

8.1

Tags:

Complexity:

Sprint Focus:

Description

The method getFileContents in YamlFileLoader has return type string, but it has
a call to file_get_contents that can return string or false. Ensure that a string
is always returned.

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Bug #99926: PHP Warning when file does not exists.

Closed

Thomas Hohn

2023-02-10

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Thomas Hohn over 1 year ago

Subject changed from Ensure that getFileContents returns correct type to Ensure that getFileContents returns correct type in YamlFileLoader

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions

Copy link

Updated by Simon Schaufelberger over 1 year ago

Related to Bug #99926: PHP Warning when file does not exists. added

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984

Actions

Copy link

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/77991

Actions

Copy link