Project

General

Profile

Actions

Task #100067

closed

Streamline logging in TypoScriptFrontendController->set_no_cache

Added by Thomas Hohn over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Logging
Start date:
2023-03-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
Sprint Focus:

Description

TYPO3 will, when set_no_cache is called, issue a log WARNING that contains either a caller provided reason for why it was called or alternatively a pointer to what code called it, generated by calling the backtrace function.
In addition to the plain set_no_cache logging case, there is also the related but somewhat separate "disableNoCacheParameter" handling that logs as a WARNING if set_no_cache is logged, but is ignored by the [TYPO3_CONF_VARS][FE][disableNoCacheParameter]. This also triggers a WARNING.

Instead both scenarios should just issue a Notice.
We could deprecate the $internal variable in v12 as proposed in https://forge.typo3.org/issues/97815


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #97815: Excessive logging in TypoScriptFrontendController set_no_cacheClosed2022-06-27

Actions
Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #2

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #7

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78010

Actions #8

Updated by Thomas Hohn over 1 year ago

  • Subject changed from Streamline logging in TypoScriptFrontendController::set_no_cache to Streamline logging in TypoScriptFrontendController->set_no_cache
Actions #9

Updated by Christian Kuhn over 1 year ago

  • Related to Task #97815: Excessive logging in TypoScriptFrontendController set_no_cache added
Actions #10

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78122

Actions #11

Updated by Thomas Hohn over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #12

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF