Project

General

Profile

Actions

Bug #100076

closed

Inconsistent value of \TYPO3\CMS\Core\Imaging\GraphicalFunctions::getImageScale

Added by Rémy DANIEL over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Image Cropping
Target version:
-
Start date:
2023-03-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Depending of the inputs, getImageScale returns either int or float for the scaled width/heigth.

This can triggers strict type warnings in calling code, if width/heigth are expected to be integers.

Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78019

Actions #2

Updated by Rémy DANIEL over 1 year ago

  • Assignee set to Rémy DANIEL
Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78019

Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78057

Actions #5

Updated by Rémy DANIEL over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF