Project

General

Profile

Actions

Task #100151

closed

asset.css ViewHelper contains not working link to changelog

Added by Sybille Peters over 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Category:
Documentation
Target version:
-
Start date:
2023-03-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

This is wrong and there is no link rendered:

:ref:`changelog-Feature-90522-IntroduceAssetCollector`

( This would work in the changelog to link to another changelog, but does not work in the VHref as that is a different manual! )

I would remove this entirely, because:

  • there are no other links to changelogs in the ViewHelper ref
  • the changelog is from 10.4
  • linking to older changelogs is not necessarily good practice since the description may have since been outdated.

Correct would be either

1. Use :doc: and a partial path
2. OR use :ref:, but add the name of the manual (core). This must also be added to the Settings.cfg which is currently not the case

:ref:`ext_core:changelog-Feature-90522-IntroduceAssetCollector`

3. Use link directly https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.3/Feature-90522-IntroduceAssetCollector.html

If it were only the PHPDoc, I would use @link and the absolute URL. Don't know how that will work in rendered ViewHelper reference.

Actions #1

Updated by Sybille Peters over 1 year ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78105

Actions #3

Updated by Sybille Peters over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #4

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78055

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78106

Actions #6

Updated by Sybille Peters over 1 year ago

  • Status changed from Under Review to Resolved
Actions #7

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch 10.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78106

Actions #8

Updated by Sybille Peters over 1 year ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF