Bug #100152
closed
Multiple warnings in PhpStorm due to "class-string" in phpDocs
0%
Description
PhpStorm checks passed function parameters and tells that a parameter to GeneralUtility::makeInstance() should be class-string but passed is string. This happens at every usage (like in GeneralUtility::makeInstance(ConnectionPool::class)). Problem is with commit 3bb114c9dc1 (https://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/3bb114c9dc1). Suddenly the project is full with useless warnings.
It would be good if phpDoc does not break common IDEs.
See the attachment for the PhpStorm report.
Files
Updated by Georg Ringer over 1 year ago
- Related to Task #99146: Improve the type annotations around GU::makeInstance & friends added
Updated by Georg Ringer over 1 year ago
- Is duplicate of Task #100091: Introduce phpstan- prefixed annotations for makeInstance() added
Updated by Georg Ringer over 1 year ago
- Status changed from New to Needs Feedback
IMO fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/78031. can you recheck and vote?
Updated by Dmitry Dulepov over 1 year ago
I adjusted a copy of v12.2.0 manually - yes, it is solved with this change. Thanks, Georg! I will add my review.
Updated by Georg Ringer over 1 year ago
- Status changed from Needs Feedback to Closed
thanks for super fast response. closing issue here as duplicate