Project

General

Profile

Actions

Bug #100166

closed

INCLUDE_TYPOSCRIPT stopped being deep recursive in v12

Added by Dmitry Dulepov over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2023-03-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

I have the following directory strucure:

localPackages/composer/template/Configuration/TypoScript/
├── Setup
│   ├── Config.typoscript
│   ├── Lib
│   │   ├── ContentElement.typoscript
│   │   ├── ParseFuncRte.typoscript
│   │   └── Register.typoscript
│   ├── Page.typoscript
│   ├── Plugin
│   │   ├── News
│   │   │   └── setup.typoscript
│   │   ├── Solr
│   │   │   └── setup.typoscript
│   │   └── Template
│   │       ├── Settings.typoscript
│   │       └── View.typoscript
│   └── TtContent
│       ├── Content.typoscript
│       ├── Element.typoscript
│       └── ImageElement.typoscript
├── constants.typoscript
└── setup.typoscript

setup.typoscript:

<INCLUDE_TYPOSCRIPT: source="DIR:EXT:template/Configuration/TypoScript/Setup/" extensions="typoscript">

In TYPO3 before v12 it would include every file with typoscript extension. In v12 it does not (see attachments named 01-*). Looks like it only includes a single immediate layer and one sublevel. I can see the content of Setup/Config.typoscript but not the content of Setup/Plugin/Template/Settings.typoscript.

If I include like this:

<INCLUDE_TYPOSCRIPT: source="DIR:EXT:template/Configuration/TypoScript/Setup/Plugin/" extensions="typoscript">

then I can see included TS from the next level - Setup/Plugin/Template/Settings.typoscript (see attachments named 02-*).

I believe it should work exactly the same way as it did before v12: include everything recursively. This a very convenient feature for projects with a lot of TS files in hierarchies. Limiting it to just one level seriously degrades functionality.

Please, make it work like before. Thanks!


Files

01-including-setup.jpg (479 KB) 01-including-setup.jpg PhpStorm view of TS hierarchy, inclusion and content Dmitry Dulepov, 2023-03-14 17:49
01-ts.jpg (381 KB) 01-ts.jpg TS object browser for inclusiog of .../Setup/ Dmitry Dulepov, 2023-03-14 17:49
02-including-plugin.jpg (480 KB) 02-including-plugin.jpg PhpStorm view of TS hierarchy, inclusion and content Dmitry Dulepov, 2023-03-14 17:49
02-ts.jpg (431 KB) 02-ts.jpg TS object browser for inclusiog of .../Setup/Plugin/ Dmitry Dulepov, 2023-03-14 17:49

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #97816: New TypoScript parserClosed2022-06-27

Actions
Actions #1

Updated by Christian Kuhn over 1 year ago

Actions #2

Updated by Alexander Grein over 1 year ago

I just encountered the (same?) problem in one of my projects i just tried to update from 11 to 12.

In all my project sitepackages I have a "AutoInclude" folder with subfolders for separating typoscript files into several groups:

sitepackage/Configuration/TypoScript
├── AutoInclude
│   ├── 010_Start
│   │   ├── 010_Basics.t3c
│   │   ├── 020_BootstrapPackage.t3c
│   │   ├── 020_BootstrapPackage.t3s
│   │   └── 030_Theme.t3c
│   ├── 020_Page
│   │   ├── 010_Config.t3s
│   │   └── 020_Includes.t3s
│   └── 030_Extensions
│       ├── 010_Felogin.t3c
│       ├── 010_Felogin.t3s
│       ├── 020_Seo.t3c
│       └── 020_Seo.t3s
├── constants.typoscript
└── setup.typoscript

My typoscript to include them looks like this:

constants.typoscript

<INCLUDE_TYPOSCRIPT: source="DIR:EXT:interconnection/Configuration/TypoScript/AutoInclude" extensions="t3c">

setup.typoscript

<INCLUDE_TYPOSCRIPT: source="DIR:EXT:interconnection/Configuration/TypoScript/AutoInclude" extensions="t3s">

With TYPO3 12.3.0 this is not working anymore.

E.g. no constant set inside e.g. sitepackage/Configuration/TypoScript/AutoInclude/010_Start/010_Basics.t3c will be handled correctly.

If there is e.g. a typoscript constant definition like this:

config.headerComment = Made with love by web agency xyz 

Which I use inside sitepackage/Configuration/TypoScript/AutoInclude/020_Page/010_Config.t3s like so:

config.headerComment = {$config.headerComment}

The result in the generated html code is:

{$config.headerComment}

Actions #3

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78569

Actions #4

Updated by Christian Kuhn over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF