Bug #100174
closedfelogin: Recovery mail type mismatch
100%
Description
TYPO3\CMS\FrontendLogin\Service\RecoveryService::prepareMail() creates an object of type TYPO3\CMS\Core\Mail\FluidEmail\FluidEmail but returns it as Symfony\Component\Mime\Email. This mistyped mail object is subsequently used in TYPO3\CMS\FrontendLogin\Event\SendRecoveryEmailEvent.
I would like to propose to use only FluidEmail within classes RecoveryService and SendRecoveryEmailEvent to make the code more consistent and avoid problems in code that listens to SendRecoveryEmailEvent to manipulate e.g. the contents of the password recovery email to be sent.
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78384
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78384
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78384
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78384
Updated by Gerrit Code Review over 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78928
Updated by Andreas Nedbal over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset cc40fc060ca50dc3705eec5490658b43aa27fe13.
Updated by Gerrit Code Review over 1 year ago
- Status changed from Resolved to Under Review
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78928
Updated by Andreas Nedbal over 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset 359b9ab6883c48f47fcf6c47cd95d704dede6299.