Task #100355
closed
Deprecate methods in PasswordChangeEvent
100%
Description
The PasswordChangeEvent used in notifyPasswordChange can be used to intercept a password from being saved. It is however not possible to visualize to the user, why the password has not been saved, since no error message is passed to the frontend.
At the point, where the PasswordChangeEvent is dispatched, the password has already been validated by validateHashAndPasswords, so it is more or less redundant to validate it again in notifyPasswordChange.
The functions setAsInvalid, getErrorMessage and isPropagationStopped of the PasswordChangeEvent should therefore be deprecated. This allows us to remove the whole notifyPasswordChange function and the redundant calls to findOneByForgotPasswordHash.
Updated by Torben Hansen almost 2 years ago
- Subject changed from Deprecate PasswordChangeEvent in ext:felogin to Deprecate methods in PasswordChangeEvent
Updated by Gerrit Code Review almost 2 years ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446
Updated by Gerrit Code Review almost 2 years ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446
Updated by Gerrit Code Review almost 2 years ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446
Updated by Torben Hansen almost 2 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset d3b3c062cb9e579bf4beb176183503b42b660065.
Updated by