Project

General

Profile

Actions

Task #100355

closed

Deprecate methods in PasswordChangeEvent

Added by Torben Hansen about 1 year ago. Updated 3 months ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
-
Target version:
Start date:
2023-03-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The PasswordChangeEvent used in notifyPasswordChange can be used to intercept a password from being saved. It is however not possible to visualize to the user, why the password has not been saved, since no error message is passed to the frontend.

At the point, where the PasswordChangeEvent is dispatched, the password has already been validated by validateHashAndPasswords, so it is more or less redundant to validate it again in notifyPasswordChange.

The functions setAsInvalid, getErrorMessage and isPropagationStopped of the PasswordChangeEvent should therefore be deprecated. This allows us to remove the whole notifyPasswordChange function and the redundant calls to findOneByForgotPasswordHash.

Actions #1

Updated by Torben Hansen about 1 year ago

  • Description updated (diff)
Actions #2

Updated by Torben Hansen about 1 year ago

  • Subject changed from Deprecate PasswordChangeEvent in ext:felogin to Deprecate methods in PasswordChangeEvent
Actions #3

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446

Actions #5

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78446

Actions #6

Updated by Torben Hansen about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF