Project

General

Profile

Actions

Bug #100412

closed

Wrong YAML configuration for Number form element

Added by Guido Jansen over 1 year ago. Updated 6 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Form Framework
Target version:
-
Start date:
2023-04-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The YAML configuration for the Number form element in file
EXT:form/Configuration/Yaml/FormElements/Number.yaml
has an error.

TYPO3:
  CMS:
    Form:
      prototypes:
        standard:
          formElementsDefinition:
            Number:
              formEditor:
                editors:
                  # ---
                  700:
                    identifier: step
                    templateName: Inspector-TextEditor
                    label: formEditor.elements.TextMixin.editor.step.label
                    configurationOptions:
                      viewPorts:
                        # ---
                      numbersOfColumnsToUse:
                    propertyPath: properties.fluidAdditionalAttributes.step
                    propertyValidators:
                      10: Integer
                  # ---

So the 700 editor is like a mixture between the step configuration from the Date form element configuration and
the gridColumnViewPortConfiguration from all the other form elements

The consequence of this misconfiguration is that the Grid viewport configuration is not shown

I suggest that the configuration should be like

TYPO3:
  CMS:
    Form:
      prototypes:
        standard:
          formElementsDefinition:
            Number:
              formEditor:
                editors:
                  # ---
                  550:
                    identifier: step
                    templateName: Inspector-TextEditor
                    label: formEditor.elements.TextMixin.editor.step.label
                    propertyPath: properties.fluidAdditionalAttributes.step
                    propertyValidators:
                      10: Integer
                  700:
                    identifier: gridColumnViewPortConfiguration
                    templateName: Inspector-GridColumnViewPortConfigurationEditor
                    label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.label
                    configurationOptions:
                      viewPorts:
                        10:
                          viewPortIdentifier: xs
                          label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.xs.label
                        20:
                          viewPortIdentifier: sm
                          label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.sm.label
                        30:
                          viewPortIdentifier: md
                          label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.md.label
                        40:
                          viewPortIdentifier: lg
                          label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.lg.label
                        50:
                          viewPortIdentifier: xl
                          label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.xl.label
                        60:
                          viewPortIdentifier: xxl
                          label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.xxl.label
                      numbersOfColumnsToUse:
                        label: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.numbersOfColumnsToUse.label
                        propertyPath: 'properties.gridColumnClassAutoConfiguration.viewPorts.{@viewPortIdentifier}.numbersOfColumnsToUse'
                        fieldExplanationText: formEditor.elements.FormElement.editor.gridColumnViewPortConfiguration.numbersOfColumnsToUse.fieldExplanationText
                  # ---


Files

number-without-grid-viewport-configuration.png (32.4 KB) number-without-grid-viewport-configuration.png Without Grid viewport configuration Guido Jansen, 2023-04-03 14:40
number-with-grid-viewport-configuration.png (44.4 KB) number-with-grid-viewport-configuration.png With Grid viewport configuration Guido Jansen, 2023-04-03 14:40

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #98930: Add configuration of GridColumn viewportsClosed2022-10-26

Actions
Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78444

Actions #2

Updated by Christian Kuhn over 1 year ago

  • Related to Task #98930: Add configuration of GridColumn viewports added
Actions #3

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78444

Actions #4

Updated by Oliver Bartsch over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Gerrit Code Review over 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78561

Actions #6

Updated by Oliver Bartsch over 1 year ago

  • Status changed from Under Review to Resolved
Actions #7

Updated by Benni Mack 6 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF