Project

General

Profile

Actions

Bug #100428

closed

TYPO3 v12 Database Upgrade is never fulfilled

Added by Alexander Opitz about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Should have
Category:
Install Tool
Target version:
-
Start date:
2023-04-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

On TYPO3 12.3.0 running the command 'vendor/bin/typo3 upgrade:run' leads to the error message

"Error running Database Up-to-Date. Please ensure this prerequisite manually and try again."

This is repetitive, as we only "add" database changes here but no indexes. The issue was introduced in https://review.typo3.org/c/Packages/TYPO3.CMS/+/58128 in file https://review.typo3.org/c/Packages/TYPO3.CMS/+/58128/10/typo3/sysext/install/Classes/Updates/DatabaseUpdatedPrerequisite.php and function ensure()

        $result = null;
        if (count($adds) > 0) {
            $this->output->writeln('Performing ' . count($adds) . ' database operations.');
            $result = $this->upgradeWizardsService->addMissingTablesAndFields();
        }
        return $result === null;

The addMissingTablesAndFields() returns an empty array, if no errors exists, so we try to check empty array against null. Uncool.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #100491: Improve some type annotations in DB-upgrade-related classesClosedOliver Klee2023-04-05

Actions
Actions #1

Updated by Alexander Opitz about 1 year ago

  • Assignee set to Alexander Opitz
Actions #2

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #5

Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #6

Updated by Oliver Klee about 1 year ago

  • Related to Task #100491: Improve some type annotations in DB-upgrade-related classes added
Actions #7

Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #8

Updated by Gerrit Code Review about 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #9

Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #10

Updated by Gerrit Code Review about 1 year ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #11

Updated by Gerrit Code Review about 1 year ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #12

Updated by Gerrit Code Review about 1 year ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447

Actions #13

Updated by Markus Klein about 1 year ago

  • TYPO3 Version changed from 12 to 11
Actions #14

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79301

Actions #15

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79354

Actions #16

Updated by Alexander Opitz about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF