Project

General

Profile

Actions

Bug #100572

closed

Module configuration - own navigation component not loaded

Added by Andreas Pfeiffer over 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
Start date:
2023-04-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hello,

when i register a backend sub module with an own navigation component, this component is not visible. Always the component from the main module is loaded. Even i set "inheritNavigationComponentFromMainModule" to true, no navigation at all is loaded.

I guess the problem is located in "vendor/typo3/cms-backend/Classes/Module/BaseModule.php" line 246.

if (isset($configuration['inheritNavigationComponentFromMainModule'])) {
    $obj->inheritNavigationComponent = (bool)$configuration['inheritNavigationComponentFromMainModule'];
} elseif (isset($configuration['navigationComponent'])) {
    $obj->navigationComponent = (string)$configuration['navigationComponent'];
} elseif (isset($configuration['navigationComponentId'])) {
    $obj->navigationComponent = (string)$configuration['navigationComponentId'];
}

If i set "inheritNavigationComponentFromMainModule", the first "if" is done - but the others not anymore. Like this i disable the parent navigation component, but mine is never used. Shouldn´t it be like:

if (isset($configuration['inheritNavigationComponentFromMainModule'])) {
    $obj->inheritNavigationComponent = (bool)$configuration['inheritNavigationComponentFromMainModule'];
}

if (isset($configuration['navigationComponent'])) {
    $obj->navigationComponent = (string)$configuration['navigationComponent'];
}

if (isset($configuration['navigationComponentId'])) {
    $obj->navigationComponent = (string)$configuration['navigationComponentId'];
}

Thank you.

Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78616

Actions #2

Updated by Oliver Bartsch over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF