Project

General

Profile

Actions

Bug #100774

closed

Fluid Select ViewHelper getIdentifierByObject failes

Added by Marc Hirdes about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Fluid
Target version:
Start date:
2023-04-28
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

In the Fluid Select ViewHelper line 238 the call of $this->persistenceManager->getIdentifierByObject misses a check if the $value is an object.

} elseif ($this->persistenceManager->getIdentifierByObject($value) !== null) {

It also could be an array. If so, then an error is shown.

The fix would be:

} elseif (is_object($value) && $this->persistenceManager->getIdentifierByObject($value) !== null) {

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #100790: Provide meaningful error messages for misconfigured SelectViewHelperClosed2023-05-02

Actions
Actions #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889

Actions #2

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889

Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889

Actions #5

Updated by Gerrit Code Review about 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78889

Actions #6

Updated by Oliver Bartsch about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review about 1 year ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78918

Actions #8

Updated by Oliver Bartsch about 1 year ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Nikita Hovratov 10 months ago

  • Related to Task #100790: Provide meaningful error messages for misconfigured SelectViewHelper added
Actions

Also available in: Atom PDF