Project

General

Profile

Actions

Bug #100896

open

Console error triggered after click on edit button for a translated page

Added by Julian Mair over 1 year ago. Updated about 1 month ago.

Status:
Under Review
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2023-05-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
8.1
Tags:
Complexity:
Is Regression:
Sprint Focus:
Stabilization Sprint

Description

Upon clicking the edit button on a translated page, the UI overlay remains while the web console generates an error.

Error message:

VM5260 form-engine.js:13 Uncaught (in promise) TypeError: Cannot set properties of null (setting 'disabled')
    at VM5260 form-engine.js:13:12668
    at NodeList.forEach (<anonymous>)
    at Object.initializeLocalizationStateSelector (VM5260 form-engine.js:13:12438)
    at Object.reinitialize (VM5260 form-engine.js:13:12217)
    at VM5260 form-engine.js:13:21565

Possible solution:
On the line in file: https://github.com/TYPO3/typo3/blob/v12.4.1/Build/Sources/TypeScript/backend/form-engine.ts#L743
Wouldn't it be more appropriate for the condition to be the following, rather than undefined?

if (input === null) {

System:
  • Typo3 v12.4.1
  • PHP 8.1

Files

Actions #1

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79094

Actions #2

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79094

Actions #3

Updated by Benni Mack over 1 year ago

  • Sprint Focus set to Stabilization Sprint
Actions #4

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79094

Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79094

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79719

Actions #7

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79007

Actions #8

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79007

Actions #9

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79774

Actions #10

Updated by Georg Ringer over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Gerrit Code Review about 1 month ago

  • Status changed from Closed to Under Review

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79094

Actions

Also available in: Atom PDF