Bug #101113
closedSystem reports will show that there are no redirects conflicts even if the checkintegrity command was never run
100%
Description
Update : the implementation in the patch is a little different than described here: We create an additional status if checkintegrity was not run or is outdated. The status which shows ok or redirects is still displayed.
Ideally the "reports" checks if checkintegrity was run lately (e.g. within last 24 hours) and
- if checkintegrity was run and no conflicts: OK
- no redirects exist: OK
- if checkintegrity was not run (lately) and no conflicts (known): WARNING or INFO, e.g. "there are no known redirect conflicts, please run checkintegrity"
- if there are conflicts: WARNING (as before)
Reproduce¶
1. Create conflicts (e.g. rename slug of page twice)
2. confirm conflict by loading the page and check TYPO3 log (in case of redirect to self there will be something like " Redirect /styleguide-demo-1/test/redrects points to itself! Aborting" in log
3. look in report: will show OK. No indication that this is incorrect or something needs to be done.
4. confirm checkintegrity finds something (will show 1 conflict):
php typo3/sysext/core/bin/typo3 redirects:checkintegrity
I expect a WARNING instead of OK status in report if there are conflicts and checkintegrity was never used or not used recently.
Screenshots (current core version)¶
Status: "Ok" (blissfully unaware of pending doom)
Status: after running checkintegrity
also, the text is weird, but that's another issue.
Screenshot (implementation, see patch)¶
This is current version in patch, not in core!:
Files
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Sybille Peters over 1 year ago
- Related to Feature #99485: Show the redirect integrity status added
Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Gerrit Code Review over 1 year ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79452
Updated by Sybille Peters over 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e969b10c381f199d7be3cdcdc9cec97534710c12.
Updated by Chris Müller over 1 year ago
- Related to Task #102037: Fix rendering warning in redirects system extension added