Project

General

Profile

Actions

Bug #101150

closed

Image editing doesn't work when more than one image is assigned.

Added by Stephan grass 12 months ago. Updated 12 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Image Cropping
Target version:
Start date:
2023-06-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If I assign more than one image to an element (text-media, resources in page properties...), the image editing feature stops working. The wizard opens multiple times for the first image, corresponding to the number of images assigned, making it unusable. The wizard doesn't load at all for the other images.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #100948: Remove jquery & jquery-ui from image manipulation widgetClosed2023-06-02

Actions
Actions #1

Updated by Wittkiel Gruppe 12 months ago

Same problem for us with TYPO3 12.4.2 and Firefox 114.0.2 and Chrome 114.0.5735.134.

Easy to reproduce:
1. Select for example "Images Only" in wizard "Create new content element"
2. Click "Add image" in CE
3. Select 2 or more images and click "Import selection"
4. Don't save and click "Open Editor" for first image (buttons etc. are broken), click "Open Editor" for second image (now CE is loaded again without data)

With an already saved CE sometimes it seems to work.

Actions #2

Updated by Jasmina Ließmann 12 months ago

  • Category set to Image Cropping
  • Target version set to next-patchlevel

I can confirm the issue.

1 / Content element was created, images added and not saved yet

If you click the image crop button of the first image the wizard will open. When clicking on the button "Accept" the browser console returns an error for <img src="${e.src}" style="${styleMap(d)}">:

2image-manipulation.js:18 Uncaught TypeError: Cannot read properties of undefined (reading 'src')
    at image-manipulation.js:18:27
    at Array.forEach (<anonymous>)
    at ImageManipulation.setPreviewImages (image-manipulation.js:15:2478)
    at ImageManipulation.save (image-manipulation.js:21:661)
    at HTMLButtonElement.<anonymous> (image-manipulation.js:13:7108)
    at ModalElement.<anonymous> (/typo3/sysext/core/R…lar-event.js:13:433)

When clicking on the button "Cancel" in the wizard, the wizard appears to close but another instance remains open until you click the 'x' icon in the image crop wizard.

If you click the image crop button of the second image, the content element will reload and lose its state.

2 / Content element was created, images added and saved

The behaviour persists even when the content element has been saved, but the problematic behaviour varies. For example, if you open the previously saved content element and open the image crop wizard of the second image, everything works fine. After closing this image crop wizard and click on the button to open the image crop wizard of the first image the content element will be reloaded and the changes will be lost. The behavior reverses depending on which image you start with.

Actions #3

Updated by Andreas Kienast 12 months ago

  • Related to Task #100948: Remove jquery & jquery-ui from image manipulation widget added
Actions #4

Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555

Actions #5

Updated by Gerrit Code Review 12 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555

Actions #6

Updated by Gerrit Code Review 12 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555

Actions #7

Updated by Gerrit Code Review 12 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555

Actions #8

Updated by Gerrit Code Review 12 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555

Actions #9

Updated by Gerrit Code Review 12 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79555

Actions #10

Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79632

Actions #11

Updated by Andreas Fernandez 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF