Project

General

Profile

Actions

Bug #101243

closed

Fix in linkvalidator PagesRepository::doesRootLineContainHiddenPages

Added by Sybille Peters 11 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2023-07-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

PagesRepository::doesRootlineContainHiddenPages() calls itself. It fetches fields from the DB without "pid" and passes the results to itself, then checks the value of pid, but this is always empty.

PagesRepository code:

42 public function doesRootLineContainHiddenPages(array $pageInfo): bool
43 {
44        $pid = (int)($pageInfo['pid'] ?? 0);

....

59 $row = $queryBuilder
60            ->select('uid', 'title', 'hidden', 'extendToSubpages')

....

72 return $this->doesRootLineContainHiddenPages($row);

Also, it is not necessary to get the title here


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #93895: Linkvalidator report doesn't list discovered bad links if the page is hiddenResolved2021-04-09

Actions
Actions

Also available in: Atom PDF