Project

General

Profile

Actions

Bug #101357

closed

Epic #99669: CKEditor5 Collection

Broken links are not marked in RTE anymore (affects linkvalidator and other extensions)

Added by Sybille Peters over 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Should have
Category:
RTE (rtehtmlarea + ckeditor)
Target version:
-
Start date:
2023-07-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Seems to be the case since v12

  • the event BrokenLinkAnalysisEvent is correctly dispatched in RteHtmlParser
  • $attributes['data-rte-error'] is set in RteHtmlParser
  • BUT, the ckeditor removes the data-rte-error attribute
  • also, the style is missing (css / sass)

Reproduce (simple, only using RTE)

1. Insert this in the RTE in Source mode:

<p><a data-rte-error="Broken link" href="https:/iambroken.org/yesreally">link</a></p>


2. switch to wysiwyg mode

The attribute data-rte-error is removed. This should not happen.

Reproduce (with linkvalidator)

  1. install linkvalidator
  2. create one or more broken links
  3. check links with linkvalidator (linkvalidator module)
  4. in list of broken links, click pencil icon

The broken links should now be marked in RTE with yellow background and red border. Also, if in source mode of RTE, you should see the attribute 'data-rte-error' in the "a" HTML elements for the broken links.


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #101360: Some attributes for <a> element are not persisted (class, rel, target) in RTEClosedSybille Peters2023-07-15

Actions
Related to TYPO3 Core - Feature #96874: Integrate CKEditor 5Closed2022-02-14

Actions
Actions #1

Updated by Sybille Peters over 1 year ago

  • Related to Bug #101360: Some attributes for <a> element are not persisted (class, rel, target) in RTE added
Actions #2

Updated by Sybille Peters over 1 year ago

  • Assignee set to Sybille Peters
Actions #3

Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #4

Updated by Sybille Peters over 1 year ago

  • Description updated (diff)
Actions #5

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #6

Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #7

Updated by Sybille Peters over 1 year ago

Actions #8

Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #9

Updated by Sybille Peters over 1 year ago

  • Description updated (diff)
Actions #10

Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #11

Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #12

Updated by Gerrit Code Review about 1 year ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035

Actions #13

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80892

Actions #14

Updated by Sybille Peters about 1 year ago

  • Status changed from Under Review to Resolved
Actions #15

Updated by Sybille Peters about 1 year ago

  • Status changed from Resolved to Under Review
Actions #16

Updated by Sybille Peters about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #17

Updated by Benjamin Franzke about 1 year ago

  • Parent task set to #99669
Actions #18

Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF