Bug #101357
closedEpic #99669: CKEditor5 Collection
Broken links are not marked in RTE anymore (affects linkvalidator and other extensions)
100%
Description
Seems to be the case since v12
- the event BrokenLinkAnalysisEvent is correctly dispatched in RteHtmlParser
- $attributes['data-rte-error'] is set in RteHtmlParser
- BUT, the ckeditor removes the data-rte-error attribute
- also, the style is missing (css / sass)
Reproduce (simple, only using RTE)¶
1. Insert this in the RTE in Source mode:
<p><a data-rte-error="Broken link" href="https:/iambroken.org/yesreally">link</a></p>
2. switch to wysiwyg mode
The attribute data-rte-error is removed. This should not happen.
Reproduce (with linkvalidator)¶
- install linkvalidator
- create one or more broken links
- check links with linkvalidator (linkvalidator module)
- in list of broken links, click pencil icon
The broken links should now be marked in RTE with yellow background and red border. Also, if in source mode of RTE, you should see the attribute 'data-rte-error' in the "a" HTML elements for the broken links.
Updated by Sybille Peters over 1 year ago
- Related to Bug #101360: Some attributes for <a> element are not persisted (class, rel, target) in RTE added
Updated by Gerrit Code Review over 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Gerrit Code Review over 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Gerrit Code Review over 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Sybille Peters over 1 year ago
- Related to Feature #96874: Integrate CKEditor 5 added
Updated by Gerrit Code Review over 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Gerrit Code Review over 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Gerrit Code Review over 1 year ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Gerrit Code Review about 1 year ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80035
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80892
Updated by Sybille Peters about 1 year ago
- Status changed from Under Review to Resolved
Updated by Sybille Peters about 1 year ago
- Status changed from Resolved to Under Review
Updated by Sybille Peters about 1 year ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a240bf92f99f3097c752cd5f7ce819c67c72290f.