Project

General

Profile

Actions
Copy link

Bug #101559

closed

Extbase view should not require renderSection and renderPartial

Added by Hannes Lau about 1 year ago. Updated 5 days ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2023-08-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Currently, extbase view resolvers must return fluid views. Fluid views need to implement `renderSection` and `renderPartial`. Those methods do not make sense for many views, such as json or xml views. The methods should not be required for all extbase views.

More technically, the return type of `\TYPO3\CMS\Extbase\Mvc\View\ViewResolverInterface::resolve` is `\TYPO3Fluid\Fluid\View\ViewInterface`.

`\TYPO3Fluid\Fluid\View\ViewInterface`:

…
    public function renderSection($sectionName, array $variables = [], $ignoreUnknown = false);
…
    public function renderPartial($partialName, $sectionName, array $variables, $ignoreUnknown = false);
…

```

Even the `\TYPO3\CMS\Extbase\Mvc\View\JsonView` is affected by this.

    public function renderSection($sectionName, array $variables = [], $ignoreUnknown = false)
    {
        // No-op: renderSection does not make sense for this view
        return '';
    }

    public function renderPartial($partialName, $sectionName, array $variables, $ignoreUnknown = false)
    {
        // No-op: renderPartial does not make sense for this view
        return '';
    }
Suggestion: Use an Extbase specific view interface which only requires the following methods:
  • assign
  • assignMultiple
  • render

Alternatively, use the `\TYPO3\CMS\Core\View\ViewInterface` instead.

Related issues 4 (0 open — 4 closed)

Related to TYPO3 Core - Feature #96730: Revamp backend templating strategyClosed2022-02-02

Actions
Related to TYPO3 Core - Task #104463: Raise typo3fluid/fluid:^2.14.0Closed2024-07-23

Actions
Related to TYPO3 Core - Task #104709: Avoid FluidViewAdapter as inner viewClosed2024-08-22

Actions
Related to TYPO3 Core - Feature #104773: Implement and use a core ViewFactoryInterfaceClosed2024-08-29

Actions
Actions
Copy link
 #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #2

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #3

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #4

Updated by Gerrit Code Review 3 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #5

Updated by Gerrit Code Review 3 months ago

Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #6

Updated by Gerrit Code Review 3 months ago

Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #7

Updated by Gerrit Code Review 3 months ago

Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #8

Updated by Gerrit Code Review 3 months ago

Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #9

Updated by Gerrit Code Review 3 months ago

Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #10

Updated by Gerrit Code Review 3 months ago

Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #11

Updated by Gerrit Code Review 3 months ago

Patch set 11 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #12

Updated by Gerrit Code Review 3 months ago

Patch set 12 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #13

Updated by Gerrit Code Review 3 months ago

Patch set 13 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #14

Updated by Gerrit Code Review 3 months ago

Patch set 14 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #15

Updated by Gerrit Code Review 3 months ago

Patch set 15 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #16

Updated by Gerrit Code Review 3 months ago

Patch set 16 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #17

Updated by Gerrit Code Review 3 months ago

Patch set 17 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #18

Updated by Gerrit Code Review 3 months ago

Patch set 18 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #19

Updated by Gerrit Code Review 3 months ago

Patch set 19 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #20

Updated by Gerrit Code Review 3 months ago

Patch set 20 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #21

Updated by Gerrit Code Review 3 months ago

Patch set 21 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #22

Updated by Gerrit Code Review 3 months ago

Patch set 22 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #23

Updated by Gerrit Code Review 3 months ago

Patch set 23 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #24

Updated by Gerrit Code Review 3 months ago

Patch set 24 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #25

Updated by Gerrit Code Review 3 months ago

Patch set 25 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #26

Updated by Gerrit Code Review 3 months ago

Patch set 26 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #27

Updated by Gerrit Code Review 3 months ago

Patch set 27 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #28

Updated by Gerrit Code Review 3 months ago

Patch set 28 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #29

Updated by Gerrit Code Review 3 months ago

Patch set 29 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #30

Updated by Gerrit Code Review 3 months ago

Patch set 30 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #31

Updated by Christian Kuhn 3 months ago

Actions
Copy link
 #32

Updated by Christian Kuhn 3 months ago

  • Related to Task #104463: Raise typo3fluid/fluid:^2.14.0 added
Actions
Copy link
 #33

Updated by Gerrit Code Review 3 months ago

Patch set 31 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #34

Updated by Gerrit Code Review 3 months ago

Patch set 32 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80329

Actions
Copy link
 #35

Updated by Hannes Lau 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #36

Updated by Christian Kuhn about 2 months ago

  • Related to Task #104709: Avoid FluidViewAdapter as inner view added
Actions
Copy link
 #37

Updated by Christian Kuhn about 2 months ago

  • Related to Feature #104773: Implement and use a core ViewFactoryInterface added
Actions
Copy link
 #38

Updated by Benni Mack 5 days ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF