Project

General

Profile

Actions

Bug #101718

closed

DatabaseRecordLinkBuilder does not respect language setting for all languages (sys_language_uid = -1)

Added by Philipp Radler 8 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
-
Start date:
2023-08-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
8.1
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

I encountered the bug after I created a custom recordLink config like the one described in the TYPO3 Docs.

config{
  recordLinks.example {
    typolink {
        parameter = 123
        additionalParams.data = field:uid
        additionalParams.wrap = &tx_example_pi1[item]=|&tx_example_pi1[controller]=Item&tx_example_pi1[action]=show
    }
  }
}

As I want to show my records an every available language without translating them, they are set to sys_language_uid = -1 (all languages).
The problem is the DatabaseRecordLinkBuilder (EXT:frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php) does not support this behaviour, which is indeed a bug.

Currently on Line 65 in DatabaseRecordLinkBuilder.php it states the following.

                if (empty($overlay['_LOCALIZED_UID'])) {
                    $record = 0;
                }

This has been fixed in V12, please fix for V11 also.


Related issues 4 (2 open2 closed)

Related to TYPO3 Core - Bug #100931: No link generated for record with language 'all languages'Resolved2023-05-30

Actions
Related to TYPO3 Core - Task #101229: Update DatabaseRecordLinkBuilder.phpResolved2023-07-04

Actions
Related to TYPO3 Core - Story #101565: Frontend related translation issuesNew2023-08-03

Actions
Related to TYPO3 Core - Bug #98079: No localized records will be rendered in custom record link handlersNew2022-08-05

Actions
Actions #1

Updated by Christian Kuhn 8 months ago

  • Related to Bug #100931: No link generated for record with language 'all languages' added
Actions #2

Updated by Christian Kuhn 8 months ago

  • Related to Task #101229: Update DatabaseRecordLinkBuilder.php added
Actions #3

Updated by Astrid Haubold 6 months ago

  • Related to Story #101565: Frontend related translation issues added
Actions #4

Updated by Benni Mack 6 months ago

  • Status changed from New to Needs Feedback

I think this might be fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/79696 ? released in one of the latest v12 bugfix releases. Can you confirm?

Actions #5

Updated by Philipp Radler 6 months ago

Benni Mack wrote in #note-4:

I think this might be fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/79696 ? released in one of the latest v12 bugfix releases. Can you confirm?

Yes this has been fixed in v12. I'm requesting a bugfix for v11, would be awesome if this can be fixed in this version too.

Actions #6

Updated by Gerrit Code Review 3 months ago

  • Status changed from Needs Feedback to Under Review

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82775

Actions #7

Updated by Gerrit Code Review 3 months ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/82775

Actions #8

Updated by Benni Mack 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Daniel Siepmann 14 days ago

  • Related to Bug #98079: No localized records will be rendered in custom record link handlers added
Actions

Also available in: Atom PDF