Project

General

Profile

Actions

Bug #98079

open

No localized records will be rendered in custom record link handlers

Added by Marcel Marty over 1 year ago. Updated 14 days ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
Link Handling, Site Handling & Routing
Target version:
Start date:
2022-08-05
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Since TYPO3 11.5.5, no localized records in custom record link handlers are displayed.

Steps to reproduce:

  1. Create a TYPO3 installation with 2 languages (in my case default is DE and the other language is FR)
  2. Create a basic extension which is creating records
  3. Create a record and localize this record to FR.
  4. Create a custom link handler as described in the official documentation at https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/LinkBrowser/Linkhandler/Index.html
  5. Create a content element in the default language with an RTE field and some text
  6. Localize the content element from 2)
  7. Link to a specified record by the previously generated custom record link handler in the default language
  8. Link to the localized version of a specified record in the localized content element from 3)

Conclusion:

The link in the default language will appear in the frontent, the link in the localized content element will not.

Suggestion:

The problem will be caused because of an incomplete condition in typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php file (line 66-68, change for #87260).

In my opinion the condition should be:

if (empty($overlay['_LOCALIZED_UID']) && empty($overlay['l10n_parent'])) {
   $record = 0;
} 

instead of
if (empty($overlay['_LOCALIZED_UID'])) {
   $record = 0;
}

because the property _LOCALIZED_UID is not available in Extbase records (I have just l10n_parent there).


Related issues 3 (1 open2 closed)

Related to TYPO3 Core - Story #101565: Frontend related translation issuesNew2023-08-03

Actions
Related to TYPO3 Core - Bug #101718: DatabaseRecordLinkBuilder does not respect language setting for all languages (sys_language_uid = -1)Resolved2023-08-21

Actions
Blocked by TYPO3 Core - Bug #87260: Untranslated records should not be linkedClosedMathias Brodala2018-12-21

Actions
Actions #1

Updated by Marcel Marty over 1 year ago

  • Blocked by Bug #87260: Untranslated records should not be linked added
Actions #2

Updated by Marcel Marty over 1 year ago

  • Target version set to next-patchlevel
Actions #3

Updated by Frank Gerards over 1 year ago

as stated in the other bugticket https://forge.typo3.org/issues/87260:

Situation: Language EN-US falls back to EN-GB, Default Language 0 is DE-DE.
Page exists in DE-DE and EN-GB (free mode), but not in EN-US:

Now you call the page in EN-US, which completely falls back to EN-GB:

If you have "Jump" Contentelements, which link to other content-elements (not page links, which work fine) on the same or other pages, then NO links (as $record = 0 is returned) will be created. This breaks the fallback chain and language handling of bigger sites totally. No content fallback to languages other than default can be done.

Your fix doesnt solve the problem. I am talking about a frontend request to a site language, which has a fallback language OTHER than language 0 (default). In this situation, the LinkHandler returns $row = 0.

The tt_content record which is running through the handler is the one of the fallback language (!), which ofc has no l10n_parent and no _LOCALIZED_UID as it is the fallback record. This mis-understanding of language fallback kicked in with the introduction of the Site module and its placemnet in the core-logic. In former TYPO3 versions, multi-stage language fallbacks could be done with the CORE or additionally with TemplaVoila and with a slight patch even in extbase.

The site module and new routing is pretty broken, if you move out of basic language handling. It also can't handle mixed mode of page translations for extbase plugins accordingly.

I would suggest to abandon the "fix" in https://forge.typo3.org/issues/87260 completely.

Actions #4

Updated by Frank Gerards over 1 year ago

My proposal für a fix would be:

    if (
        empty($overlay['_LOCALIZED_UID'])
        && empty($overlay['l10n_parent'])
        && !in_array($record['sys_language_uid'],$languageAspect->getFallbackChain())
       ) {
            $record = 0;
      }

So if it is NOT a record of a fallback-chain language, then abandon the link. Otherwise, its correct to link to the element.

Actions #5

Updated by Daniel Siepmann over 1 year ago

The current behaviour is also broken in case you don't have a default language version of a certain record which you'll link.

1. Create two languages
2. Create a record in 2nd language (not default)
3. Link to that record from within 2nd language

The link will not exist as there is no default record and no localized uid.

Actions #6

Updated by Oliver Hader over 1 year ago

  • Sprint Focus set to On Location Sprint
Actions #7

Updated by Benni Mack 9 months ago

  • Sprint Focus deleted (On Location Sprint)
Actions #8

Updated by Astrid Haubold 6 months ago

  • Related to Story #101565: Frontend related translation issues added
Actions #9

Updated by Daniel Siepmann 14 days ago

  • Related to Bug #101718: DatabaseRecordLinkBuilder does not respect language setting for all languages (sys_language_uid = -1) added
Actions #10

Updated by Daniel Siepmann 14 days ago

Actions

Also available in: Atom PDF