Project

General

Profile

Actions
Copy link

Bug #101749

closed

EXT:form element type URL element inspector shows a stray Validator label without options

Added by Benjamin Franzke about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Benjamin Franzke
Category:
Form Framework
Target version:
13.0
Start date:
2023-08-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
13
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the deprecation removal of regular expressions
based EXT:form validators in #101070, the set of available
validators for the form element type URL became empty.
(See EXT:form/Configuration/Yaml/FormElements/Url.yaml)

Instead of only removing the select element from the DOM,
the entire form-group should e removed, in order to also hide
the corresponding <label> tag, as such a stray label tag
isn't hehlpful for an enduser and is therefore actually even
invalid HTML (as the reference to an input element is missing).

Files

formeditor-url-zero-validators.png (30.7 KB) formeditor-url-zero-validators.png Benjamin Franzke, 2023-08-25 04:05

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #101070: Remove RegularExpressionValidator based validation in ext:formClosed2023-06-14

Actions
Actions
Copy link
 #1

Updated by Benjamin Franzke about 1 year ago

  • Related to Task #101070: Remove RegularExpressionValidator based validation in ext:form added
Actions
Copy link
 #2

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80692

Actions
Copy link
 #3

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80692

Actions
Copy link
 #4

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80730

Actions
Copy link
 #5

Updated by Benjamin Franzke about 1 year ago

Reproducible in v11/v12 by editing typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml

remove all but the empty validator (10:):

                       20:
                         value: Alphanumeric
                         label: formEditor.elements.TextMixin.editor.validators.Alphanumeric.label
                       40:
                         value: StringLength
                         label: formEditor.elements.TextMixin.editor.validators.StringLength.label
                       50:
                         value: EmailAddress
                         label: formEditor.elements.TextMixin.editor.validators.EmailAddress.label
                       60:
                         value: Integer
                         label: formEditor.elements.TextMixin.editor.validators.Integer.label
                       70: 
                         value: Float
                         label: formEditor.elements.TextMixin.editor.validators.Float.label
                       80: 
                         value: NumberRange
                         label: formEditor.elements.TextMixin.editor.validators.NumberRange.label
                       90: 
                         value: RegularExpression
                         label: formEditor.elements.TextMixin.editor.validators.RegularExpression.label

Actions
Copy link
 #6

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80734

Actions
Copy link
 #7

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80692

Actions
Copy link
 #8

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80730

Actions
Copy link
 #9

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80734

Actions
Copy link
 #10

Updated by Anonymous about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF