Bug #101749
closedEXT:form element type URL element inspector shows a stray Validator label without options
100%
Description
With the deprecation removal of regular expressions
based EXT:form validators in #101070, the set of available
validators for the form element type URL became empty.
(See EXT:form/Configuration/Yaml/FormElements/Url.yaml)
Instead of only removing the select element from the DOM,
the entire form-group should e removed, in order to also hide
the corresponding <label> tag, as such a stray label tag
isn't hehlpful for an enduser and is therefore actually even
invalid HTML (as the reference to an input element is missing).
Files
Updated by Benjamin Franzke 10 months ago
- Related to Task #101070: Remove RegularExpressionValidator based validation in ext:form added
Updated by Gerrit Code Review 10 months ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80692
Updated by Gerrit Code Review 10 months ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80692
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80730
Updated by Benjamin Franzke 10 months ago
Reproducible in v11/v12 by editing typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml
remove all but the empty validator (10:
):
20: value: Alphanumeric label: formEditor.elements.TextMixin.editor.validators.Alphanumeric.label 40: value: StringLength label: formEditor.elements.TextMixin.editor.validators.StringLength.label 50: value: EmailAddress label: formEditor.elements.TextMixin.editor.validators.EmailAddress.label 60: value: Integer label: formEditor.elements.TextMixin.editor.validators.Integer.label 70: value: Float label: formEditor.elements.TextMixin.editor.validators.Float.label 80: value: NumberRange label: formEditor.elements.TextMixin.editor.validators.NumberRange.label 90: value: RegularExpression label: formEditor.elements.TextMixin.editor.validators.RegularExpression.label
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80734
Updated by Gerrit Code Review 10 months ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80692
Updated by Gerrit Code Review 10 months ago
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80730
Updated by Gerrit Code Review 10 months ago
Patch set 2 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80734
Updated by Anonymous 10 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b8a9e450ae3daf459b0b72b4592a14e8687b8e75.