Task #101783
closed
Check for stray build sources in CI
100%
Description
We currently have a mixture of some .js files still authored without TypeScript and some .js files being stray build outputs, where no usage or source file is present.
Ideally we'd check via CI whether all .js files in our tree are "valid", that means can be recreated as is.
Command used to find cases:
find typo3 -name '*.js' -exec rm '{}' + && (cd Build && npm run build)&>/dev/null && LC_ALL=C git status | grep deleted | grep -v /Fixtures/
Output:
deleted: typo3/sysext/backend/Resources/Public/Html/Close.js
deleted: typo3/sysext/backend/Resources/Public/JavaScript/Helper.js
deleted: typo3/sysext/core/Resources/Public/JavaScript/Contrib/sortablejs.js
deleted: typo3/sysext/core/Resources/Public/JavaScript/ReferrerRefresh.js
deleted: typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/muuri.js
deleted: typo3/sysext/form/Resources/Public/JavaScript/Frontend/DatePicker.js
deleted: typo3/sysext/frontend/Resources/Public/JavaScript/default_frontend.js
deleted: typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/typo3conf-migrations-check.js
deleted: typo3/sysext/reactions/Resources/Public/JavaScript/management-overview.js
deleted: typo3/sysext/scheduler/Resources/Public/JavaScript/editable-group-title.js
deleted: typo3/sysext/t3editor/Resources/Public/JavaScript/Contrib/@lezer/common.js
deleted: typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/completion-result.js
deleted: typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-code-completion.js
deleted: typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-parser.js
deleted: typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-ref.js
deleted: typo3/sysext/t3editor/Resources/Public/JavaScript/stream-parser/typoscript.js
Updated by
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80765
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80765
Updated by Gerrit Code Review about 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80765
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869
Updated by Gerrit Code Review about 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80765
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869
Updated by Gerrit Code Review about 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80765
Updated by Gerrit Code Review about 1 year ago
Patch set 3 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869
Updated by Gerrit Code Review about 1 year ago
Patch set 4 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80869
Updated by Anonymous about 1 year ago
- Status changed from Under Review to Resolved
Applied in changeset 4f1c1368f9e4f07bf552fab15a659c422e5c9eb5.
Updated by