Project

General

Profile

Actions

Task #101783

closed

Check for stray build sources in CI

Added by Benjamin Franzke about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Category:
Backend JavaScript
Start date:
2023-08-29
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

We currently have a mixture of some .js files still authored without TypeScript and some .js files being stray build outputs, where no usage or source file is present.

Ideally we'd check via CI whether all .js files in our tree are "valid", that means can be recreated as is.

Command used to find cases:

find typo3 -name '*.js' -exec rm '{}' + && (cd Build && npm run build)&>/dev/null && LC_ALL=C git status | grep deleted | grep -v /Fixtures/

Output:

    deleted:    typo3/sysext/backend/Resources/Public/Html/Close.js
    deleted:    typo3/sysext/backend/Resources/Public/JavaScript/Helper.js
    deleted:    typo3/sysext/core/Resources/Public/JavaScript/Contrib/sortablejs.js
    deleted:    typo3/sysext/core/Resources/Public/JavaScript/ReferrerRefresh.js
    deleted:    typo3/sysext/dashboard/Resources/Public/JavaScript/Contrib/muuri.js
    deleted:    typo3/sysext/form/Resources/Public/JavaScript/Frontend/DatePicker.js
    deleted:    typo3/sysext/frontend/Resources/Public/JavaScript/default_frontend.js
    deleted:    typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/typo3conf-migrations-check.js
    deleted:    typo3/sysext/reactions/Resources/Public/JavaScript/management-overview.js
    deleted:    typo3/sysext/scheduler/Resources/Public/JavaScript/editable-group-title.js
    deleted:    typo3/sysext/t3editor/Resources/Public/JavaScript/Contrib/@lezer/common.js
    deleted:    typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/completion-result.js
    deleted:    typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-code-completion.js
    deleted:    typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-parser.js
    deleted:    typo3/sysext/t3editor/Resources/Public/JavaScript/autocomplete/ts-ref.js
    deleted:    typo3/sysext/t3editor/Resources/Public/JavaScript/stream-parser/typoscript.js


Subtasks 7 (0 open7 closed)

Task #101784: Fix npmcopy of @lezer/commonClosedBenjamin Franzke2023-08-29

Actions
Task #101785: Fix npm update of sortablejsClosedBenjamin Franzke2023-08-29

Actions
Task #101786: Remove stray JavaScript build filesClosedBenjamin Franzke2023-08-29

Actions
Task #101787: Fix npm update of muuriClosedBenjamin Franzke2023-08-29

Actions
Task #101790: Migrate helper entry point scripts to TypeScriptClosedBenjamin Franzke2023-08-29

Actions
Task #101795: Migrate @typo3/t3editor/autocomplete/* to TypeScriptClosedBenjamin Franzke2023-08-30

Actions
Task #101803: Migrate @typo3/t3editor/stream-parser/typoscript to TypeScriptClosedBenjamin Franzke2023-08-30

Actions
Actions

Also available in: Atom PDF