Project

General

Profile

Actions

Task #101896

closed

Prune global TypeScript types

Added by Benjamin Franzke about 1 year ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Category:
Backend JavaScript
Start date:
2023-09-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

  • Only define type definitions via "types"
    that need to be globally available.
    See https://www.typescriptlang.org/tsconfig#types
    > If `types` is specified, only packages listed will
    > be included in the global scope

    Those whose exports are (and can be) imported locally
    are not included globally bot only explicitly via
    `import` by the typescript modules that make actually
    use of these dependencies.

  • Move declarations from global into local scope that were
    actually only defined and used in specific files.
  • Remove unnecessary `declare module` statements that
    shadowed type definitions that are avaiable right now: * This means muuri is now type checked, which revealed
    wrong usage in the dashboard grid and is fixed right away
Actions #1

Updated by Gerrit Code Review about 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80943

Actions #2

Updated by Gerrit Code Review about 1 year ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80943

Actions #3

Updated by Gerrit Code Review about 1 year ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80943

Actions #4

Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80991

Actions #5

Updated by Anonymous about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF