Project

General

Profile

Actions
Copy link

Bug #102075

closed

linkvalidator email should contain the full url

Added by Philipp Kuhlmay about 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Linkvalidator
Target version:
Candidate for patchlevel
Start date:
2023-10-02
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

I run the linkvalidator for my website and the linkvalidator sends me an email, when it found some wrong urls. that's correct.
But when I click at a link inside this mail, I get an error inside my web browser. This is, because the link inside the email is not correct. It only shows the first X letters of the link.

I always have to log in and then navigate to the page in the backend and then find the content element. It would be much easier, if the email already contains the full URL to the wrong page.

Files

Download all files
Bildschirmfoto 2023-10-02 um 09.49.23.png (55.5 KB) Bildschirmfoto 2023-10-02 um 09.49.23.png Philipp Kuhlmay, 2023-10-02 07:51
Bildschirmfoto 2023-10-02 um 09.52.53.png (16.7 KB) Bildschirmfoto 2023-10-02 um 09.52.53.png Philipp Kuhlmay, 2023-10-02 07:53
Actions
Copy link
 #1

Updated by Oliver Bartsch about 1 year ago

  • Status changed from New to Needs Feedback

Hi,

thanks for your report. Actually the targets are no links. Your E-Mail client seems to automatically transform the string to a link. Not showing the full link is due to missing space in the email template (However, the full link is set as title - so depending on your client, you should see the full link on hovering). Additionally, linking those invalid external links makes IMO no sense at all, because they would obviously not work.

Actions
Copy link
 #2

Updated by Philipp Kuhlmay about 1 year ago

Hi, you are right. My E-Mail client shows this link. In mailpit (inside ddev) I don't get this link.

I could fix this for me with the following change:
<td><span title="{link.target}" aria-label="{link.target}"><f:link.external uri="{link.target}" title="{link.record_title}">{link.target -> f:format.crop(maxCharacters: 15)}</f:link.external></span></td>

inside EXT:linkvalidator/Resources/Private/Templates/Email/ValidatorTask.html:38

Now I get the short title with the dots ... and I also get a link.

Actions
Copy link
 #3

Updated by Oliver Bartsch about 1 year ago

All right. This however is a cutstom solution since external is only one type of link. However as you might know you can just use your own template with your modifications, see: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/11.0/Breaking-29342-ImproveValidatorTask.html.

If this works for you, I would suggest to close this issue.

Actions
Copy link
 #4

Updated by Georg Ringer 5 months ago

  • Status changed from Needs Feedback to Closed

closed as suggested by oli

Actions
Copy link

Also available in: Atom PDF